Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2709: move tov example parfile out of cell in notebook into file in einsteinexamples
by Roland Haas 28 Apr '23

28 Apr '23

#2709: move tov example parfile out of cell in notebook into file in einsteinexamples Reporter: Roland Haas Status: resolved Milestone: Version: Type: enhancement Priority: minor Component: Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2709/move-tov-example-…

1 0

#2721: Cactus does not detect `gettimeofday` timer
by Roland Haas 28 Apr '23

28 Apr '23

#2721: Cactus does not detect `gettimeofday` timer Reporter: Erik Schnetter Status: open Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): There is one other “odd' uses of `AC_TRY_XXX` in Cactus \(not failures like this one thoug in `CCTK_CHECK_C_INLINE` we have ``` AC_TRY_COMPILE(, [} $ac_kw int foo() {], [cctk_cv_c_inline=$ac_kw; break]) ``` which probably would be nicer if it did: ``` AC_TRY_COMPILE($ac_kw int foo(){return 0;}], [], [cctk_cv_c_inline=$ac_kw; break]) ``` since it does not “trick” autoconf by closing the autoconf created `main` function with the leading `}`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…

1 0

#2711: attempting to build KadathThorn assumes a git repository
by tootle 28 Apr '23

28 Apr '23

#2711: attempting to build KadathThorn assumes a git repository Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by tootle): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} Thanks for finding the work around! Based on these changes, I needed to modify the build script for the \`KadathThorn\`. In [4cca4c8](https://bitbucket.org/fukaws/kadaththorn/commits/4cca4c8a6cd4e4427… I removed the manual git pull that took place before and updated copying files correctly to the scratch directory based on the new symbolic links In [cc91146](https://bitbucket.org/fukaws/kadaththorn/commits/cc9114684da656587… I removed the submodule since this is no longer needed. I have since tested the build procedure and everything worked on my end. Let me know if there are any further issues. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2711/attempting-to-bui…

1 0

#2721: Cactus does not detect `gettimeofday` timer
by Roland Haas 28 Apr '23

28 Apr '23

#2721: Cactus does not detect `gettimeofday` timer Reporter: Erik Schnetter Status: open Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): The global variable declaration I don’t buy. Since those look like: ```c extern int errno ``` whether they are in the function or not does not matter $and the `extern` is required for the declaration otherwise it would be a repeated definition each time the header file is included$. Same with function prototypes: ```c int printf(fmt, ...); ``` is valid inside of main. Inline function _definitions_ being forbidden seems correct, yes, those cannot be nested in `main`. It is, in any case, bad practise to have the header includes in main, even if it may have been allowable at one point in C’s history. Would it be ok to apply this after the release unless there is urgent need to have this fixed right now? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…

1 0

#2721: Cactus does not detect `gettimeofday` timer
by Erik Schnetter 28 Apr '23

28 Apr '23

#2721: Cactus does not detect `gettimeofday` timer Reporter: Erik Schnetter Status: open Milestone: Version: Type: bug Priority: major Component: Comment (by Erik Schnetter): Yes, this is forbidden. Consider e.g. a global variable declaration, or the definition of an inline function. These have very different meaning when inside a function, or are not allowed. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…

1 0

#2721: Cactus does not detect `gettimeofday` timer
by Roland Haas 27 Apr '23

27 Apr '23

#2721: Cactus does not detect `gettimeofday` timer Reporter: Erik Schnetter Status: open Milestone: Version: Type: bug Priority: major Component: Changes (by Roland Haas): responsible: [] (was ) assignee: Roland Haas (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…

1 0

#2721: Cactus does not detect `gettimeofday` timer
by Roland Haas 27 Apr '23

27 Apr '23

#2721: Cactus does not detect `gettimeofday` timer Reporter: Erik Schnetter Status: open Milestone: Version: Type: bug Priority: major Component: Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…

1 0

#2721: Cactus does not detect `gettimeofday` timer
by Roland Haas 27 Apr '23

27 Apr '23

#2721: Cactus does not detect `gettimeofday` timer Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): The current code works for me $e.g. on the Delta Cluster at UIUC, and also on Summit$. I get: ``` /* Timing stuff */ #define HAVE_TIME_GETTIMEOFDAY 1 #define GETTIMEOFDAY_NEEDS_TIMEZONE 1 #define HAVE_TIME_GETRUSAGE 1 ``` in `cctk_Config.h` for both. On my M1 based macOS testing system with Homebrew it does indeed fail: ``` /* Timing stuff */ /* #undef HAVE_TIME_GETTIMEOFDAY */ /* #undef GETTIMEOFDAY_NEEDS_TIMEZONE */ #define HAVE_TIME_GETRUSAGE 1 ``` So, since we have just entered code freeze for the release in May, I would not want to touch anything in configure if possible. While the change looks harmless, and indeed: ```c #include <sys/time.h> int main(void) { gettimeofday(0,0); return 0; } ``` is much nicer code $and closer to how the actual arguments to `TRY_LINK` are defined$ than ``` int main(void) { #include <sys/time.h> gettimeofday(0,0); return 0; } ``` I would rather not risk changing anything if only macOS system are affected. Since there are no macOS production clusters, any timing obtained on them is not really useful to guide decisions for code optimization anyway I would think. I would be happy to include the change in master just after the release and backport if no issues are found with it after a while. Though note that also the change to PAPI that is reported in#2174 was applied to master just after the last release, always broke on Linux and was never reported. So master seems to not be used very much anymore it seems. Out of curiosity: ``` int main(void) { #include <sys/time.h> gettimeofday(0,0); return 0; } ``` actually forbidden? Ie does the C standard require that the includes happen at file level? There is in principle nothing wrong with declare function prototypes in local scope, and an `#include` is just a textual replacement, so valid inside of a function. ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…

1 0

#2721: Cactus does not detect `gettimeofday` timer
by Erik Schnetter 27 Apr '23

27 Apr '23

#2721: Cactus does not detect `gettimeofday` timer Reporter: Erik Schnetter Status: new Milestone: Version: Type: bug Priority: major Component: The `gettimeofday` timer is not available any more in Cactus. This is the main timer used by Cactus to measure elapsed time. PR [https://bitbucket.org/cactuscode/cactus/pull-requests/153](https://bitbucke… corrects this. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…

1 0

#2709: move tov example parfile out of cell in notebook into file in einsteinexamples
by Roland Haas 27 Apr '23

27 Apr '23

#2709: move tov example parfile out of cell in notebook into file in einsteinexamples Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Roland Haas): Thank you. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2709/move-tov-example-…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac