#2681: move CCTL_ARGUMENTS creation with other bindings code
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: enhancement
Priority: trivial
Component: Cactus
Pull request
[https://bitbucket.org/cactuscode/cactus/pull-requests/147](https://bitbucke…
moves the code and message “Generating arguments...” to happen along with the other code generating output \(“Creating FOO bindings”\) making build output more uniform.
Currently it is incorrectly indented and happens at an unusual place:
```text
Checking consistency...
Creating Thorn-Flesh bindings...
Creating implementation bindings...
Creating parameter bindings...
Creating variable bindings...
Creating schedule bindings...
Creating function bindings...
Generating arguments...
CST finished.
```
with the change the output is:
```text
Checking consistency...
Creating Thorn-Flesh bindings...
Creating implementation bindings...
Creating parameter bindings...
Creating variable bindings...
Creating schedule bindings...
Creating function bindings...
Generating arguments...
CST finished.
```
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2681/move-cctl_argumen…
#2670: Refinement prolongation: All points must have been received
Reporter:
Status: closed
Milestone:
Version: ET_2022_05
Type: bug
Priority: major
Component: Carpet
Changes (by Roland Haas):
status: closed (was new)
Comment (by Roland Haas):
closed due to inactivity
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2670/refinement-prolon…
#2680: check licenses in CactusFoo repositories
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: enhancement
Priority: minor
Component:
Cactus code is expected to be LGPL \(or more freely I guess\) licensed. Initially what was used was GPL with a an exemption:
> This thorn is \(c\) Copyright the authors listed in the sources files. This
> thorn is distributed under the GNU GPL with the specific exception that
> the GNU GPL does not migrate to code linking to or using infrastructure
> from this thorn.
>
> - The Cactus Team [cactusmaint@cactuscode.org](mailto:cactusmaint@cactuscode.org)
eg in cactusbase/Boundary. This was then changed to be LGPL \(which amounts to the same exemption\) around 2009 and also around 2015 \(see eg commit logs in cactus\* repos\).
However some repos were missed and either show no license information at all in README or have LGPL \(in the README file\) but the GPLv2 COPYING file \(with or without the manual exemption\). Affected is eg Formaline which lists no license in its README file, but has a commit [5de0764](https://bitbucket.org/cactuscode/cactusutils/commits/5de0764e67538… "Formaline: Make Formaline GPL." of [cactusutils](https://bitbucket.org/cactuscode/cactusutils) declaring it GPL.
To change license, one actually needs permission from all copyright holders. For Formaline the list of authors \(but not necessarily copyright holders, that may actually be the respective universities and employers\) is:
Barry Wardell
Erik Schnetter
Frank Löffler
Ian Hinder
Roland Haas
Steven R. Brandt
Thomas Radke
but not all can be asked for permission anymore.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2680/check-licenses-in…
#2679: How to link an externally compiled library during ET compilation
Reporter: Maria Mutz
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component:
Comment (by Roland Haas):
This is rather strange. The optioin list looks ok to me to be honest. Adding `-lcocalmrns` to `LDFLAGS` is ok.
The error message about missing `main` is strange since `main` is provided by the Cactus flesh. Is it possible that the COCAL library defines its own `main` and that that one interferes? It would be good to see all the error messages and not just the last couple. Would you mind taking a look at [http://einsteintoolkit.org/support.html#general-guidelines-for-questions](h… and provide the files described in there, please?
Since COCAL is not part of the Einstein Toolkit \(and, at least until the recent past, had an unusual build system\), have you contacted the COCAL author \(Antonios Toskaros\), who may be able to provide advise as well?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2679/how-to-link-an-ex…
#2679: How to link an externally compiled library during ET compilation
Reporter: Maria Mutz
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component:
Changes (by Roland Haas):
responsible: [] (was )
component: (was EinsteinToolkit thorn)
priority: minor (was major)
assignee: Roland Haas (was )
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2679/how-to-link-an-ex…
#2679: How to link an externally compiled library during ET compilation
Reporter: Maria Mutz
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
I have compiled the COCAL code separately from the ET, generating a library for which I have the .a file. I’m trying to link to that library when compiling the ET on Expanse. When I try to link it without copying all the source files in the thorn that uses it into the src directory I get “undefined reference to” errors for anything in a subdirectory. I tried moving all the files in subdirectories into the src directory as a work-around, but then I started getting errors that look like this:
\`\`\`
/lib/../lib64/crt1.o: In function \`\_start':
\(.text\+0x24\): undefined reference to \`main'
collect2: error: ld returned 1 exit status
make\[3\]: \*\*\* \[<builtin>: include\_modulefiles\_MRNS.f90\] Error 1
make\[2\]: \*\*\* \[/home/mmutz/Cactus/lib/make/make.thornlib:113: make.checked\] Error 2
make\[1\]: \*\*\* \[/home/mmutz/Cactus/lib/make/make.configuration:179: /home/mmutz/Cactus/configs/sim17/lib/libthorn\_Cocalthorn.a\] Error 2
\`\`\`
What is the proper way to link the library during compilation?
I’ve attached a copy of my config file.
attachment: OptionList.pdf (https://api.bitbucket.org/2.0/repositories/einsteintoolkit/tickets/issues/2…)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2679/how-to-link-an-ex…