#2621: keep running into nan ,need help
Reporter: Artectek
Status: new
Milestone: ET_2022_05
Version: ET_2022_05
Type: task
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Artectek):
To my understanding ,cold tabulated EOS is just a multipoly eos with much more points,i tried increase the resolution even more to ~140m,but it is still the same,this time is:
```
INFO (NSTracker): Found star at (11.5312,-2.90625,0)
138090 1294.594 | 6.1129402 | 0.0003189 0.0019738 | 0.0008331 | 2.0279669 | 0.0010922 | 19715
INFO (CarpetTracker): Setting position of refined region #1 from surface #0 to (11.5312,-2.90625,0)
INFO (CarpetTracker): Setting position of refined region #2 from surface #1 to (-11.5312,2.90625,0)
INFO (NSTracker): Found star at (11.5312,-2.90625,0)
138092 1294.612 | 6.1129794 | 0.0003189 0.0019739 | 0.0008331 | 2.1415209 | 0.0010950 | 19715
INFO (CarpetTracker): Setting position of refined region #1 from surface #0 to (11.5312,-2.90625,0)
INFO (CarpetTracker): Setting position of refined region #2 from surface #1 to (-11.5312,2.90625,0)
INFO (NSTracker): Found star at (11.5312,-2.90625,0)
138094 1294.631 | 6.1129793 | 0.0003189 0.0019739 | 0.0008331 | 2.2870158 | 0.0010950 | 19715
INFO (CarpetTracker): Setting position of refined region #1 from surface #0 to (11.5312,-2.90625,0)
INFO (CarpetTracker): Setting position of refined region #2 from surface #1 to (-11.5312,2.90625,0)
INFO (NSTracker): Found star at (11.5312,-2.90625,0)
138096 1294.650 | 6.1130046 | 0.0003189 0.0019739 | 0.0008331 | 1.8727232 | 0.0010921 | 19715
INFO (CarpetTracker): Setting position of refined region #1 from surface #0 to (11.5312,-2.90625,0)
INFO (CarpetTracker): Setting position of refined region #2 from surface #1 to (-11.5312,2.90625,0)
INFO (NSTracker): Found star at (11.5312,-2.90625,0)
138098 1294.669 | 6.1129553 | -nan 0.0019739 | 0.0008331 | 1.2863624 | 0.0010853 | 19715
```
‌
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2621/keep-running-into…
#2598: thornyflat - production run segmentation fault
Reporter: Maria
Status: new
Milestone:
Version: ET_2021_11
Type: bug
Priority: major
Component:
Comment (by Maria):
I agree with Anuj being in charge. Anuj, please try to work with the support team for Thorny Flat to fix the problem with MPI and keep the compilers up to date.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2598/thornyflat-produc…
#2626: Multipole is not OpenMP parallelized
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version:
Type: enhancement
Priority: trivial
Component:
Comment (by Ian Hinder):
When you say that Multipole is taking 1-2% of the execution time in your BBH simulation, I would say:
1. That’s not very much :slight_smile:
2. It is possible that what the timer is measuring is the time spent on one process waiting for the other processes to catch up. If you want to know, you can set `Carpet::schedule_barriers` = yes and \`Carpet::`sync_barriers` = yes\` and then look at the timer output for the barriers.
In general, I would only invest time in optimising if you have profiled first. So if you have measured that the integration loops are taking a significant amount of time, then by all means parallelise them. They don’t scale with the grid resolution \(unless you manually scale the angular resolution parameters\), and I would expect interpolation to be by far the dominant cost here.
Having said that, since it’s just adding one pragma, maybe it’s not worth investigating too much :slight_smile:
‌
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2626/multipole-is-not-…
#2625: CarpetMask should not be scheduled before SphericalSurface_Set
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Gabriele Bozzola):
I found this out possible problem. `SphericalSurface_Set` does not specify an AFTER statement for `SphericalSurface_Setup`. When I was messing around with the scheduler trying to fix this bug, I had cases in which Set was scheduled before Setup, leading to crashes.
‌
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…
#2627: Tmunu inherits from ADMBase and StaticConformal without using them
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version:
Type: bug
Priority: trivial
Component:
Comment (by Roland Haas):
Having said that… I can make the full ET compile with minimal modification \(to GRHydro which contained a leftover STORAGE statement for `conformal_state`\) when removing those inherits. It also passes all tests. I will propose them to be declared deprecated in the next release and removed afterwards.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2627/tmunu-inherits-fr…
#2627: Tmunu inherits from ADMBase and StaticConformal without using them
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version:
Type: bug
Priority: trivial
Component:
Changes (by Roland Haas):
responsible: [] (was )
assignee: Erik Schnetter (was )
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2627/tmunu-inherits-fr…
#2627: Tmunu inherits from ADMBase and StaticConformal without using them
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version:
Type: bug
Priority: trivial
Component:
Changes (by Roland Haas):
status: open (was new)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2627/tmunu-inherits-fr…
#2627: Tmunu inherits from ADMBase and StaticConformal without using them
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version:
Type: bug
Priority: trivial
Component:
Comment (by Roland Haas):
Historic leftover and backwards compatible thing I would say.
The old Tmunu mechanism \(using the FRIEND mechanism\) had a routine `TmunuBase_SetTmunu` that used `ADMCoupling`'s `STRESSENERGY_guts.h` macros, which may have conceivably used `ADMBase` variables \(at least that is my only guess\). Or it may have been superfluous when the thorn was first created in 2009. The old Tmunu code was removed in git hash [5a412c0](https://bitbucket.org/einsteintoolkit/einsteinbase/commits/5a412c0… "TmunuBase: remove deprecated support for old CalcTmunu mechanism" of [einsteinbase](https://bitbucket.org/einsteintoolkit/einsteinbase).
Right now removing it may be dicey since inheritance is transitive, that is thorns inheriting from `TmunuBase` get access to all the grid functions that `TmunuBase` inherited. There is bound to be a thorn out there that _only_ inherits from `TmunuBase` but still accesses `ADMBase` variables \(valid code in fact\).
This is probably a good candidate for a deprecated features announcement. While I doubt there are Tmunu using thorns that do not also use `ADMBase` there is a case to be made for no longer requiring `StaticConformal` in particular since support for conformaly related metrics is essentially non-existent in current codes.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2627/tmunu-inherits-fr…
#2627: Tmunu inherits from ADMBase and StaticConformal without using them
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version:
Type: bug
Priority: trivial
Component:
I am not sure if this is a bug or I am missing some second-order effect. The `Tmunu` thorn inherits from `ADMBase` and `StaticConformal` but from what I can tell it doesn’t use anything from either.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2627/tmunu-inherits-fr…