Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Gabriele Bozzola 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Gabriele Bozzola): The function in `CarpetMask` are scheduled in `SetupIMask`, which is a group provided by `CarpetReduce.` If I look at the `schedule.ccl` of `CarpetReduce`, I see ``` SCHEDULE GROUP MaskBase_SetupMask AT basegrid AFTER (SpatialCoordinates SphericalSurface_Setup) ``` Is the correct fix to add `Spherical_Surface_Set` \(or `SphericalSurface_HasBeenSet`\) among the AFTER here? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Roland Haas 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Roland Haas 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): responsible: [] (was ) assignee: Roland Haas (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Roland Haas 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Can you create a pull request \(for CarpetMask\) to fix the schedule? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Gabriele Bozzola 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Gabriele Bozzola): `CarpetMask` wants `sf_info` from `SphericalSurface`, which is initially not available. Looking at the scheduler, I can see why this is happening \(relevant section\): ``` GROUP MaskBase_SetupMask: Set up the weight function GROUP MaskBase_SetupMaskAll: Set up the weight function CarpetReduce::MaskBase_AllocateMask: [global] Allocate the weight function CarpetReduce::MaskBase_InitMask: [global] [loop-local] Initialise the weight function GROUP SetupIMaskInternal: Set up the integer weight function (schedule other routines in here) CarpetReduce::CoordBase_SetupMask: [global] [loop-local] Set up the outer boundaries of the weight function CarpetReduce::CarpetMaskSetup: [global] [loop-singlemap] Set up the weight function for the restriction regions GROUP SetupIMask: Set up the integer weight function (schedule other routines in here) CarpetMask::CarpetExcludedSetup: [global] [loop-local] Set up the weight function for the excluded regions CarpetMask::CarpetSurfaceSetup: [global] [loop-local] Set up the weight function for the excluded spherical surfaces CarpetReduce::MaskBase_SetMask: [global] [loop-local] Set the weight function GROUP SetupMask: Set up the real weight function (schedule other routines in here) CarpetReduce::MaskBase_TestMask: [global] Test the weight function SphericalSurface::SphericalSurface_Set: [global] Set surface radii to be used for initial setup in other thorns GROUP SphericalSurface_HasBeenSet: Set the spherical surfaces before this group, and use it afterwards SphericalSurface::SphericalSurface_CheckState: [global] Test the state of the spherical surfaces ``` `CarpetMask` is scheduled before `SphericalSurface_Set`, which is what sets `sf_info`. This is in the `BASEGRID` bin. As a result, masks are possibly not correctly set at iteration 0, and the run fails when presync is set to `mixed-error`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2625: CarpetMask should not be scheduled before SphericalSurface_Set
by Gabriele Bozzola 01 Aug '22

01 Aug '22

#2625: CarpetMask should not be scheduled before SphericalSurface_Set Reporter: Gabriele Bozzola Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn `CarpetMask` wants `sf_info` from `SphericalSurface`, which is initially not available. Looking at the scheduler, I can see why this is happening \(relevant section\): ``` GROUP MaskBase_SetupMask: Set up the weight function GROUP MaskBase_SetupMaskAll: Set up the weight function CarpetReduce::MaskBase_AllocateMask: [global] Allocate the weight function CarpetReduce::MaskBase_InitMask: [global] [loop-local] Initialise the weight function GROUP SetupIMaskInternal: Set up the integer weight function (schedule other routines in here) CarpetReduce::CoordBase_SetupMask: [global] [loop-local] Set up the outer boundaries of the weight function CarpetReduce::CarpetMaskSetup: [global] [loop-singlemap] Set up the weight function for the restriction regions GROUP SetupIMask: Set up the integer weight function (schedule other routines in here) CarpetMask::CarpetExcludedSetup: [global] [loop-local] Set up the weight function for the excluded regions CarpetMask::CarpetSurfaceSetup: [global] [loop-local] Set up the weight function for the excluded spherical surfaces CarpetReduce::MaskBase_SetMask: [global] [loop-local] Set the weight function GROUP SetupMask: Set up the real weight function (schedule other routines in here) CarpetReduce::MaskBase_TestMask: [global] Test the weight function SphericalSurface::SphericalSurface_Set: [global] Set surface radii to be used for initial setup in other thorns GROUP SphericalSurface_HasBeenSet: Set the spherical surfaces before this group, and use it afterwards SphericalSurface::SphericalSurface_CheckState: [global] Test the state of the spherical surfaces ``` `CarpetMask` is scheduled before `SphericalSurface_Set`, which is what sets `sf_info`. This is in the `BASEGRID` bin. As a result, masks are not correctly set at iteration 0, and the run fails when presync is set to `mixed-error`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2625/carpetmask-should…

1 0

#2549: inlcude FLRWSolver in ET
by Roland Haas 28 Jul '22

28 Jul '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Changes (by Roland Haas): responsible: [] (was []) assignee: Zach Etienne (was helvi witek) Comment (by Roland Haas): @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278} assigning to you as the new reviewer. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2601: Add four more parameters for carpet
by Roland Haas 26 Jul '22

26 Jul '22

#2601: Add four more parameters for carpet Reporter: Liwei Ji Status: resolved Milestone: Version: development version Type: enhancement Priority: major Component: Carpet Changes (by Roland Haas): status: resolved (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2601/add-four-more-par…

1 0

#2601: Add four more parameters for carpet
by Roland Haas 26 Jul '22

26 Jul '22

#2601: Add four more parameters for carpet Reporter: Liwei Ji Status: new Milestone: Version: development version Type: enhancement Priority: major Component: Carpet Comment (by Roland Haas): Applied as git hash [8d84af01](https://bitbucket.org/eschnett/carpet/commits/8d84af01db56441e124… "Carpet: update comments for split interior" of [carpet](https://bitbucket.org/eschnett/carpet) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2601/add-four-more-par…

1 0

#2601: Add four more parameters for carpet
by Liwei Ji 24 Jul '22

24 Jul '22

#2601: Add four more parameters for carpet Reporter: Liwei Ji Status: new Milestone: Version: development version Type: enhancement Priority: major Component: Carpet Comment (by Liwei Ji): Hi Roland. I have update the pull request according to the discussion we had before. Could you please take a look again? thanks -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2601/add-four-more-par…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac