#2599: nsnstohmns cannot be reproduced using LORENE2
Reporter: Ken Hui
Status: open
Milestone: ET_2021_05
Version: ET_2021_05
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
So based on your tests their seems to be good evidence that indeed the change in constants in `unites.h` is responsible or the failure \(since you can make LORENE1 runs fail but only changing `unites.h`\).
Unfortunately, I doubt there is much the ET can do about this since the changes in the constants are all on the <1% level. Other than a warning to use “compatible” versions of LORENE when reading in data files, which in itself is not terribly helpful. If LORENE encodes a version number in its output files, then the ET can try and check the number and warn if the version number in the file disagrees with the runtime version. It will generate a lot of false positive “version does not match, be careful” warnings so most likely will be ignored by most researchers.
For the gallery example, it may be possible to make things work by using a slightly higher resolution \(the one the gallery is very low, and really not science-worthy\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2599/nsnstohmns-cannot…
#963: Improve McLachlan accuracy
Reporter: Erik Schnetter
Status: open
Milestone:
Version:
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
@{557058:f7fd5133-6eee-4385-a5e5-3e03342a0b24} did you have time to look into this?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/963/improve-mclachlan-…
#2554: init_3_timelevels produces nans on past timelevels of the initial slice
Reporter: Yosef Zlochower
Status: open
Milestone:
Version: ET_2021_05
Type: bug
Priority: minor
Component: Carpet
Comment (by Roland Haas):
@{557058:d079f9c2-ad27-47b2-bf4b-ecc6bbe288b0} says \(private email\): The fix works for me. I no longer get Nans in the output files.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2554/init_3_timelevels…
#2596: EinsteinInitialData/TwoPunctures: Allocated memory is not freed
Reporter: Zach Etienne
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component:
Changes (by Roland Haas):
status: open (was new)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2596/einsteininitialda…
#2596: EinsteinInitialData/TwoPunctures: Allocated memory is not freed
Reporter: Zach Etienne
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component:
Comment (by Roland Haas):
Can you provide a diff instead of the edited file, please? The edited file makes it harder to see what was actually changed and thus review.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2596/einsteininitialda…
#2599: nsnstohmns cannot be reproduced using LORENE2
Reporter: Ken Hui
Status: open
Milestone: ET_2021_05
Version: ET_2021_05
Type: bug
Priority: minor
Component: Cactus
Comment (by Ken Hui):
The definition of those 3 physical constants do not match between LORENE1 and LORENE2. The initial data of the gallery simulation nsnstohmns is \(I supposed\) taken from [https://lorene.obspm.fr/data/binNS.html](https://lorene.obspm.fr/data/binNS…, which should have been generated with an older LORENE version. That’s why I tried to change the physical constants in LORENE2, to recover their old values.
```
--- lorene1_unites.h.ori 2022-03-11 13:14:02.810753230 +0800
+++ lorene2_unites.h.ori 2022-03-11 02:08:27.660497092 +0800
@@ -26,8 +26,20 @@
/*
- * $Id: unites.h,v 1.4 2004/12/01 12:28:32 p_grandclement Exp $
+ * $Id: unites.h,v 1.8 2015/03/17 14:20:00 j_novak Exp $
* $Log: unites.h,v $
+ * Revision 1.8 2015/03/17 14:20:00 j_novak
+ * New class Hot_eos to deal with temperature-dependent EOSs.
+ *
+ * Revision 1.7 2014/10/13 08:52:37 j_novak
+ * Lorene classes and functions now belong to the namespace Lorene.
+ *
+ * Revision 1.6 2014/06/30 14:34:57 j_novak
+ * Update of the values of some constants (G, M_sol and MeV).
+ *
+ * Revision 1.5 2014/05/13 10:06:12 j_novak
+ * Change of magnetic units, to make the Lorene unit system coherent. Magnetic field is now expressed in Lorene units. Improvement on the comments on units.
+ *
* Revision 1.4 2004/12/01 12:28:32 p_grandclement
* Include math.h in unite.h
*
@@ -47,50 +59,55 @@
* Initial revision
*
*
- * $Header: /cvsroot/Lorene/C++/Include/unites.h,v 1.4 2004/12/01 12:28:32 p_grandclement Exp $
+ * $Header: /cvsroot/Lorene/C++/Include/unites.h,v 1.8 2015/03/17 14:20:00 j_novak Exp $
```
Indeed I have tried to update the values of G, M\_sol and MeV in LORENE1 according to the 2014 revision, recompile ET and run the nsnstohmns simulations. The Carpet errors came up again at the exact same time step.
For the plot of the grids, I am having problem visualising it in gnuplot. Allow me to attach the raw output here for the moment, I will also try to see if I can plot them using other methods later.
[https://drive.google.com/drive/folders/1iutL\_5avKqVTQxDCvqb8dIY5QwB6A\_PN?…
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2599/nsnstohmns-cannot…