Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2584: Carpet defines globally visible functions without a "Carpet" prefix in their names
by Roland Haas 26 Dec '21

26 Dec '21

#2584: Carpet defines globally visible functions without a "Carpet" prefix in their names Reporter: Roland Haas Status: open Milestone: Version: development version Type: bug Priority: minor Component: Carpet Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2584/carpet-defines-gl…

1 0

#2584: Carpet defines globally visible functions without a "Carpet" prefix in their names
by Roland Haas 26 Dec '21

26 Dec '21

#2584: Carpet defines globally visible functions without a "Carpet" prefix in their names Reporter: Roland Haas Status: new Milestone: Version: development version Type: bug Priority: minor Component: Carpet Comment (by Roland Haas): Pull request is here: [https://bitbucket.org/eschnett/carpet/pull-requests/48/carpet-prefix-public… For C code this should be source code compatible since it uses a couple of `#define` to map `CallScheduleGroup` to `CarpetCallScheduleGroup` but the Fortran interface defined using `CCTK_FNAME(CallScheduleGroup)` cannot be fixed that way since Fortran code does not \(tend to\) include any header file. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2584/carpet-defines-gl…

1 0

#2584: Carpet defines globally visible functions without a "Carpet" prefix in their names
by Roland Haas 26 Dec '21

26 Dec '21

#2584: Carpet defines globally visible functions without a "Carpet" prefix in their names Reporter: Roland Haas Status: new Milestone: Version: development version Type: bug Priority: minor Component: Carpet In `carpet_public.h` \(the C header\) Carpet defines a couple of helper functions that do not have the thorn name anywhere in them: ```c /* Call a schedule group */ int CallScheduleGroup(cGH *const cgh, const char *const group); /* Call a local function */ int CallLocalFunction(cGH *const cgh, void (*const function)(cGH *const cgh)); int CallSinglemapFunction(cGH *const cgh, void (*const function)(cGH *const cgh)); int CallLevelFunction(cGH *const cgh, void (*const function)(cGH *const cgh)); int CallGlobalFunction(cGH *const cgh, void (*const function)(cGH *const cgh)); int CallMetaFunction(cGH *const cgh, void (*const function)(cGH *const cgh)); ``` which causes conflicts with CarpetX, that defines an aliased \(much better\) function `CallScheduleGroup` . Cactus thorn providing callable functions should prefix them by their thorn name to avoid name conflicts. Since these functions have been around for a while \(and I think the one in conflict with CarpetX is used by CT\_Multipole\) some sort of backwards compatible solution that avoids the linker name clashes should be provided. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2584/carpet-defines-gl…

1 0

#2512: Enable detection of `attribute(pure)`
by Roland Haas 26 Dec '21

26 Dec '21

#2512: Enable detection of `attribute(pure)` Reporter: Erik Schnetter Status: open Milestone: Version: development version Type: proposal Priority: minor Component: Cactus Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2512/enable-detection-…

1 0

#2512: Enable detection of `attribute(pure)`
by Roland Haas 26 Dec '21

26 Dec '21

#2512: Enable detection of `attribute(pure)` Reporter: Erik Schnetter Status: new Milestone: Version: development version Type: proposal Priority: minor Component: Cactus Comment (by Roland Haas): Applied as git hash [6d8feee1](https://bitbucket.org/cactuscode/cactus/commits/6d8feee1ca8de65a7… "Cactus: enable detection of attributes const and pure" of [cactus](https://bitbucket.org/cactuscode/cactus) for testing. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2512/enable-detection-…

1 0

#2512: Enable detection of `attribute(pure)`
by Roland Haas 26 Dec '21

26 Dec '21

#2512: Enable detection of `attribute(pure)` Reporter: Erik Schnetter Status: new Milestone: Version: development version Type: proposal Priority: minor Component: Cactus Comment (by Roland Haas): Pull request is here: [https://bitbucket.org/cactuscode/cactus/pull-requests/134/cactus-enable-det… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2512/enable-detection-…

1 0

#2384: cctk.h includes cctk_Arguments.h
by Roland Haas 26 Dec '21

26 Dec '21

#2384: cctk.h includes cctk_Arguments.h Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: trivial Component: Cactus Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2384/cctkh-includes-cc…

1 0

#2384: cctk.h includes cctk_Arguments.h
by Roland Haas 26 Dec '21

26 Dec '21

#2384: cctk.h includes cctk_Arguments.h Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: trivial Component: Cactus Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2384/cctkh-includes-cc…

1 0

#2384: cctk.h includes cctk_Arguments.h
by Roland Haas 26 Dec '21

26 Dec '21

#2384: cctk.h includes cctk_Arguments.h Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: trivial Component: Cactus Comment (by Roland Haas): Pull requests are: * [https://bitbucket.org/canuda/proca/pull-requests/4/proca-include-cctk\_argu… * [https://bitbucket.org/zach\_etienne/wvuthorns\_diagnostics/pull-requests/8/… * [https://bitbucket.org/cactuscode/cactus/pull-requests/133/cactus-move-sched… ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2384/cctkh-includes-cc…

1 0

#2583: use DECLARE_CCTK_PARAMETERS in Cactus flesh
by Roland Haas 25 Dec '21

25 Dec '21

#2583: use DECLARE_CCTK_PARAMETERS in Cactus flesh Reporter: Roland Haas Status: new Milestone: Version: development version Type: enhancement Priority: minor Component: Cactus Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2583/use-declare_cctk_…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac