#2571: runtime failure due to useing character*8 in DECLARE_CCTK_ARGUMENTS_CHECKED macro
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: Cactus
I just learned \(via Skype\) that Cactus' use of `character*8` variables can cause runtime errors in Fortran:
```
At line 13 of file Cactus/arrangements/EinsteinBase/TmunuBase/src/SetStressEnergyState.F90
Fortran runtime error: Actual string length is shorter than the declared one for dummy argument 'dtbetax_p' (0/8)
```
and digging down a bit and looking at the processed Fortran file \(configs/sim/build/TmunuBase/SetStressEnergyState.f90\) one finds:
```fortran
characTer*8, intent(IN) :: dtbetax_p
integer, parameter :: cctki_use_dtbetax_p = kind(dtbetax_p)
```
and [https://stackoverflow.com/questions/4780069/passing-a-string-as-an-argument… where the Fortran 2003 standard gets quoted with an explanation:
> If a scalar dummy argument is of type default character, the length len of the dummy argument shall be less than or equal to the length of the actual argument. The dummy argument becomes associated with the leftmost len characters of the actual argument.
This all used gfortran 11.
Safest would be if we could declare as `characTer*0` if that is allowed. Of course it’s still wrong in that the actual argument passed to `dtbetax_p` is never a character at all \(it’s either a double precision real or NULL\) and we only use the `characTer` construct to avoid assignment and also unused actual argument warnings.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2571/runtime-failure-d…
#2561: Update the simfactory entry for Expanse
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: minor
Component: SimFactory
Comment (by Gabriele Bozzola):
Hi Roland, I didn’t act quickly enough and the invitation expired. Can you send another one?
> Having said that: the commit seems to indicate that “numpy” fails, so you are using numpy in your rpar files?
Yes, that is correct.
> The pull request also adds a line
```
OPENBLAS_DIR = /cm/shared/apps/spack/cpu/opt/spack/linux-centos8-zen2/gcc-10.2.0/openblas-0.3.10-3lzjcwjsyu3qmott7k3k52mtzljioax3/
```
> to the option list which seems to go beyond the stated goal of fixing some issue with Python, at least at first glance. Adding it \(assuming that this is the correct path for the loaded module\) is the correct thing to do, but ideally should be done in a separate commit \(no stealth changes with subject lines “[whiterabbit.](http://whiterabbit.com/)exe” please\).
NumPy is compiled against OpenBlas, which has to be loaded to correctly use the package. The line ensures that OpenBlas is consistent within the environment \(ie, NumPy and Einstein Toolkit use the same OpenBlas, as it is provided by the module\). I agree that this a little bit beyond the scope of the commit, also because there is no need for NumPy and Einstein Toolkit to use the same OpenBlas.
In general, following the discussion in the mailing list \([http://lists.einsteintoolkit.org/pipermail/users/2021-August/008179.html](http://lists.einsteintoolkit.org/pipermail/users/2021-August/008179.html)\), it is likely that this entry for Expanse is not the best one. I am waiting to see if the admins do anything about their ucx/verbs stack.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2561/update-the-simfac…
#1437: Missing option for deterministic noise in CactusNumerical/Noise
Reporter: Frank Löffler
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
@{557058:cf051f66-042f-4a92-a2c7-f2be5a7912de} didn’t you write such a pseudo-rng thorn at one point? For MC simulations?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1437/missing-option-fo…
#1265: SimFactory does not support job chaining on supermuc
Reporter: Ian Hinder
Status: wontfix
Milestone:
Version:
Type: enhancement
Priority: minor
Component: SimFactory
Changes (by Roland Haas):
status: wontfix (was new)
Error: Machine supermuc currently does not support job chaining. Please modify the submit command or submission script to support job chaining.
**Keyword:**
Comment (by Roland Haas):
SuperMUC (not SuperMUC-NG) has long since been retired.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1265/simfactory-does-n…
#1051: Generate html that has only a single page
Reporter: Erik Schnetter
Status: resolved
Milestone:
Version:
Type: enhancement
Priority: minor
Component: EinsteinToolkit website
Changes (by Roland Haas):
status: resolved (was new)
When generating html documentation, generate also a version that consists of only a single page, to make searching easier.
**Keyword:**
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1051/generate-html-tha…
#1072: User guide does not explain how to use boolean parameters from Fortran.
Reporter: Ian Hinder
Status: invalid
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Changes (by Roland Haas):
status: invalid (was new)
The Cactus user guide does not explain how to use boolean parameters from Fortran.
**Keyword:** documentation
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1072/user-guide-does-n…
#1072: User guide does not explain how to use boolean parameters from Fortran.
Reporter: Ian Hinder
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
There is an explanation present since at least git hash [3c44bc84](https://bitbucket.org/cactuscode/cactus/commits/3c44bc840a8f4ecb7… "Fixed numerous spelling errors, some grammatical boo-boos, formatting flaws \(inlcuding gratuitous hyphenation and un-dotted 'e.g.' and 'i.e'\)" of [cactus](https://bitbucket.org/cactuscode/cactus) which is from Mon Jan 5 16:28:24 2004. This is in [doc/UsersGuide/ThornWriters.tex](https://www.einsteintoolkit.org/usersguide… and currently reads:
> All parameters defined in a thorn’s param.ccl and all global parameters, appear as local variables of the corresponding CCTK data type in Fortran source code, i.e. **Booleans and Integers appear as CCTK\_INT types** \(with nonzero/zero values for boolean yes/no\), Reals as CCTK\_REAL, and Keywords and String parameters as CCTK\_STRING \(see also note below\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1072/user-guide-does-n…