#1128: Require C99 for Cactus C thorns
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
According to Erik, all systems that we need to support have good support
for C99. Many thorns use some features of C99, and it is a common error
to try to compile these without using the C99 options to a compiler. The
resulting error messages can be confusing.
In order to provide a common language platform for Cactus thorn writers,
we should state that Cactus expects the compiler to have C99 enabled. We
should test this during the configure stage and abort with a good error
message if it is not the case. Thorn writers can then assume the standard
features of C99 will always be available.
The automatically-configured compiler options in known_architectures
should be modified to enable C99 mode if it is not enabled by default for
all the recognised compilers.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1128>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#535: Add autoconf macro to test C99 style variable declarations
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
Many compilers don't support C99 style variable declarations in their
default settings. We should test this, add certain flags automatically if
we can, or abort with a clear error message otherwise.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/535>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1121: gcc 4.6+ compiler bug for isnan
---------------------+------------------------------------------------------
Reporter: sbrandt | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone: ET_2012_11
Component: Carpet | Version: development version
Keywords: |
---------------------+------------------------------------------------------
It seems that gcc 4.6 and up has a problem with compiling the isnan
function.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48891
I find that simply referring to the namespace explicitly solves it.
I had to make similar changes in Carpet/CarpetLib/src/defs.hh, but there I
had to fix isinf as well. Probably the isnormal, copysign, etc. functions
should get std:: for consistency.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1121>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#632: Changegroup hook failed when pushing to Carpet repository
--------------------+-------------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: |
--------------------+-------------------------------------------------------
When I push to the Carpet repository, I get the following message:
{{{
remote: error: changegroup.cia hook failed: http://cia.vc returned an
error: queued.
}}}
The push succeeds. What is the cause of this error?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/632>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#412: Split Appendices
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
Currently, the appendices of the users' guide are repeated into the
reference manual. This is somewhat confusing, and causes problems because
the appendices cannot easily reference other sections (e.g. "see page 15"
doesn't make sense since one doesn't know in which document this will be
read). I suggest to split the appendices and have some of them in the
users' guide while moving others into the reference manual, so that each
appendix is included in only one document
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/412>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#982: Abort with an error if the argument of --root= is not a directory
-----------------------------+----------------------------------------------
Reporter: anonymous | Owner: eric9
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: GetComponents | Version: development version
Keywords: error detection |
-----------------------------+----------------------------------------------
Currently, when GetComponnents is invoked as
GetComponents --root=<dir>
and <dir> does not exist, Getcomponents just ignores the option. I would
be better if GetComponents aborted with an error if the argument of
--root= is not a valid directory.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/982>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1112: simfactory's option parser termination option values on ";"
------------------------+---------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
I have (on my local machine horizon.tapir.caltech.edu):
{{{
rhaas@horizon:/mnt/data/rhaas/postdoc/gr/ET_trunk$ tail -n2
simfactory/etc/defs.local.ini
[horizon.tapir.caltech.edu]
user = rhaas3 ; missing
}}}
and get
{{{
rhaas@horizon:/mnt/data/rhaas/postdoc/gr/ET_trunk$ sim print-mdb-entry
horizon.tapir.caltech.edu | grep rhaas
sourcebasedir = /mnt/data/rhaas/postdoc/gr
basedir = /home/rhaas/data/postdoc/runs
user = rhaas3
email = rhaas
}}}
ie. the option parser truncates the option value for "user" at the ";"
character (seem to treat it as a comment marger like "#").
This makes it impossible to have a ";" eg. in the envsetup command. I
tried escaping the ";" with backslashes and double quotes. No luck. In my
specific case I wanted to do:
hash module && module purge ; bash ...
ie clear all module information if the module command exists (I have a
workaround for this particular application).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1112>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1120: CarpetInterp2: New ENO2 interpolator
----------------------------------------+-----------------------------------
Reporter: reisswig@… | Owner: eschnett
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: Carpet | Version:
Keywords: CarpetInterp2, eno2 |
----------------------------------------+-----------------------------------
The above patch introduces eno2 to CarpetInterp2. It works very similar to
the the original Lagrange interpolator. The only difference is that the
new interpolator uses a new class fasterp_eno2_src_loc_t instead of the
original fasterp_src_loc_t.
Similar to what is done in fasterp_src_loc_t, fasterp_eno2_src_loc_t
computes the stencil coefficients and stores them. The interpolation
algorithm with fasterp_eno2_src_loc_t is adapted for eno2.
I had to introduce templates to recycle the surrounding code in which
fasterp_src_loc_t/fasterp_eno2_src_loc_t is used.
The above patch was tested with a 2-patch and a 7-patch system, a shock
tube and an excited TOV.
The necessary changes to Llama/Interpolate2 are contained in a different
patch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1120>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit