Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma
by Zach Etienne 07 Feb '25

07 Feb '25

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: While comparing the performance of **AHFinderDirect** with my new apparent horizon finder thorn, **ET\_BHaHAHA** \(“the ET implementation of the BlackHoles@Home Apparent Horizon Algorithm”\), I observed the following runtime distribution in **AHFinderDirect**: * **AHFinderDirect\_find\_horizons**: ~56% of total runtime * **AHFinderDirect\_import\_mask**: ~31% of total runtime * **AHFinderDirect\_store**: ~13% of total runtime #### Context These measurements were taken using a slightly modified version of the **GW150914 BBH gallery example**, replacing **ML\_BSSN** with **BaikalVacuum** at a slightly higher resolution. Runtime data is based on **TimerReport cumulative runtime**. Granted, the import\_mask function takes up 0.2% of the total runtime at this find-horizon cadence, but that it takes a significant fraction of the AHFinderDirect runtime at all is simply unacceptable. #### Issue: AHFinderDirect\_import\_mask Performance The **AHFinderDirect\_import\_mask** function is particularly inefficient. It consists of a simple **3D loop** that **lacks OpenMP parallelization**, significantly impacting performance. Here’s the entire function \(with comments removed\): ``` extern "C" void AHFinderDirect_import_mask(CCTK_ARGUMENTS) { DECLARE_CCTK_ARGUMENTS_AHFinderDirect_import_mask DECLARE_CCTK_PARAMETERS assert(ahmask != 0); for (int k=0; k<cctk_lsh[2]; ++k) for (int j=0; j<cctk_lsh[1]; ++j) for (int i=0; i<cctk_lsh[0]; ++i) { const int ind = CCTK_GFINDEX3D(cctkGH,i,j,k); ahmask[ind] = 0; if (use_mask) then ahmask[ind] = fabs(emask[ind] - 1.0) > 0.01; } } ``` I would strongly recommend adding an OpenMP pragma, as follows: ``` diff --git a/AHFinderDirect/src/driver/find_horizons.cc b/AHFinderDirect/src/driver/find_horizons.cc index 67838eb..4ca0702 100644 --- a/AHFinderDirect/src/driver/find_horizons.cc +++ b/AHFinderDirect/src/driver/find_horizons.cc @@ -98,6 +98,7 @@ DECLARE_CCTK_PARAMETERS assert(ahmask != 0); +#pragma omp parallel for for (int k=0; k<cctk_lsh[2]; ++k) for (int j=0; j<cctk_lsh[1]; ++j) for (int i=0; i<cctk_lsh[0]; ++i) ``` ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2853/ahfinderdirect_im…

1 0

#2852: No error for multiple definitions of an interface group.
by Steven R. Brandt 06 Feb '25

06 Feb '25

#2852: No error for multiple definitions of an interface group. Reporter: Steven R. Brandt Status: new Milestone: ET_2025_05 Version: Type: bug Priority: major Component: Cactus Comment (by Steven R. Brandt): Pull request is here: [https://bitbucket.org/cactuscode/cactus/pull-requests/170](https://bitbucke… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2852/no-error-for-mult…

1 0

#2852: No error for multiple definitions of an interface group.
by Steven R. Brandt 06 Feb '25

06 Feb '25

#2852: No error for multiple definitions of an interface group. Reporter: Steven R. Brandt Status: new Milestone: ET_2025_05 Version: Type: bug Priority: major Component: Cactus Lucas created an interface.ccl file where two groups differed only by capitalization. To make matters worse, the variables in the 2nd group only differed from those in the first by capitalization. As a result, Cactus happily passed everything through the CST. The result was an error from the compiler about undefined variables. To make this situation less unpleasant, we should provide a clear error message for multiple definitions of the same interface group. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2852/no-error-for-mult…

1 0

#2820: NewRadX boundary condition conflicts with symmetry condition
by Roland Haas 06 Feb '25

06 Feb '25

#2820: NewRadX boundary condition conflicts with symmetry condition Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): A test case exists in [https://github.com/EinsteinToolkit/SpacetimeX/pull/39/commits/a71ff4586c8ba… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2820/newradx-boundary-…

1 0

#2851: remove explicit declaration of Cray pointer variables
by Roland Haas 02 Feb '25

02 Feb '25

#2851: remove explicit declaration of Cray pointer variables Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2851/remove-explicit-d…

1 0

#2851: remove explicit declaration of Cray pointer variables
by Roland Haas 02 Feb '25

02 Feb '25

#2851: remove explicit declaration of Cray pointer variables Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2851/remove-explicit-d…

1 0

#2851: remove explicit declaration of Cray pointer variables
by Roland Haas 02 Feb '25

02 Feb '25

#2851: remove explicit declaration of Cray pointer variables Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Pull requests for Exact and are here: [https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/20]… [https://bitbucket.org/canuda/lean\_public/pull-requests/9](https://bitbucke… ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2851/remove-explicit-d…

1 0

#2851: remove explicit declaration of Cray pointer variables
by Roland Haas 02 Feb '25

02 Feb '25

#2851: remove explicit declaration of Cray pointer variables Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Cray's own compiler fails if a POINTER\(ptr, target\) has been declared as a regalar variable before. None of the other compilers require it either. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2851/remove-explicit-d…

1 0

#2843: update FFTW3 to 3.3.10
by Roland Haas 30 Jan '25

30 Jan '25

#2843: update FFTW3 to 3.3.10 Reporter: Roland Haas Status: open Milestone: Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): Unless objected I will apply this after 2025-02-13 -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2843/update-fftw3-to-3…

1 0

#2282: gallery examples use low-order integration n Multipole
by Roland Haas 30 Jan '25

30 Jan '25

#2282: gallery examples use low-order integration n Multipole Reporter: Roland Haas Status: open Milestone: Version: Type: enhancement Priority: minor Component: EinsteinToolkit website Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2282/gallery-examples-…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac