#1071: ensure atmosphere is properly set after ID ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
ok. In that case I would think that rather than setting atmosphere_mask (which is what InitAtmosMask does) it would be better to reset the primitives and conservatives to atmosphere and not set the mask (since the mask will be cleared in the next UpdateMask anyway). I believe there is a routine in GRHydro that does this already: GRHydro_InitialAtmosphereReset which currently runs in CCTK_PostPostInitial (which scheduled is AFTER GRHydro_Rho_Minima_Setup_Final which is where grhydro_rho_min changes from its ID value to its evolution value).