#1071: ensure atmosphere is properly set after ID ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
I would expect this not to work when a hot atmosphere is evolved since calculating the Prim2Con already includes a devision by eps, which at this point might be 0. However, the current approach might also not catch this.
GRHydro_InitialAtmosphereReset only resets the primitive variables. Scheduling it right before Con2Prim looks suspicious to me. It should instead be called in HydroBase_Prim2ConInitial before Primitive2Conservative(Poly)Cells(M). Problem with that would be that GRHydro_Rho_Minima_Setup_Final didn't run yet at that point, so a relative atmosphere value wouldn't yet be known. Possible solutions would be to run GRHydro_Rho_Minima* earlier, or to do a Prim2Con again after GRHydro_InitialAtmosphereReset.