#1955: Multipole: Add possibility to have out_dir distinct from regular IO:out_dir, but default to the old behavior ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
I added some more comments. Basically:
* you could use CCTK_VERROR instead of CCTK_VWarn (so that the compiler knows that the function does not return) * please report the error code to the user
since the pull request is not on a branch in a public repo, you could do "git rebase -i" to change the commit messages without losing anything. With a merge your commit as is will show up on master, not just the single merge commit (as it would in svn).