#429: Parallelising AEILocalInterp ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: assigned Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* owner: => eschnett * status: review => assigned
Comment:
The patch mostly looks good, but I noticed two things: - next time please try to prepare two different patches: the one with restrict&const can probably be applied without discussion, and the remaining changes are then not that long - there are some #if 0 close to the new openmp statements. It would be nice to either remove them (since they are not used in any case), or if they should stay at least for some time, please use a #define to dis- or enable all at the same time, and to have some more information in the source. It reads better to have #if DISABLE_OPENMP (or similar) than #if 0
Frank