#1911: Hydro_InitExcision sphere_pugh_ppm test fails ----------------------------+----------------------------------------------- Reporter: barry.wardell | Owner: Type: defect | Status: reopened Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by eschnett):
* status: closed => reopened * resolution: invalid =>
Comment:
It should not be necessary to avoid {{{-ffast-math}}} to make the tests pass. In Cactus, we have always taken the approach that the order in which floating-point expressions are evaluated should not matter, and that we do not want to rely on IEEE semantics when it comes to NaN (or similar exceptional values).
While it would be nice to use this part of the standard, it (a) slows things down considerably, and (b) the standard doesn't guarantee bitwise identical results anyway.