#1348: simfactory doesn't support multi-core setup using setup-silent --------------------------+------------------------------------------------- Reporter: knarf | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
Fine with the 'ppn', 'max-num-threads' changes and 'num-threads'. I disagree with changing the "make" field however since the patch hard codes the assumption that the make call is "nice make -j %d" which is not necessarily true: the make invocation could set environment variables (eg INTEL_LICENSE), load extra modules, call envsetup or use a make in different location (eg. version 3.82 which *finally* reports just which dependency is missing when aborting with error 2). Also there is no need for a head node to have the same number of cores as a compute node so tying the number of make processes to the number of compute node cores seems to be unnecessary.