#114: per-variable tolerances for Cactus testsuites --------------------------+------------------------------------------------- Reporter: knarf | Owner: tbode Type: enhancement | Status: review Priority: major | Milestone: ET_2011_11 Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by hinder):
Thanks for the patch. I have the following comments: * There is some debugging code left in, some of it commented out. Probably this should be removed. * The new keywords, VarExpABSTOL and VarExpRELTOL don't fit with the all- caps conventions of other keywords accepted here. * From looking at the code, it looks like you can only specify each of these once. This means that you can only specify a variable-specific tolerance for the variables whose names match one regular expression, and only one tolerance value. Unfortunately, this might not be enough in most of the cases where this would be used. Is this correct?
Maybe a better interface would be to use the existing ABSTOL and RELTOL keywords, but to allow two arguments. The first would be the tolerance, and the second would be a regular expression determining which variables to apply this tolerance to. It would default to '.*'. Additionally, the mechanism would be extended so that more than one ABSTOL or RELTOL can be provided so that different variable patterns can have different tolerances.