#1290: parameter file parser fails to parse parameter name ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: ET_2013_05 Component: Cactus | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: review => reviewed_ok
Comment:
Has this been applied? The parfile still fails for me and looking at my Cactus checkout (rev 4997) Call.cc still contains the incorrect regex. Note that my personal choice for name would be: {{{ name = [a-zA-Z_][a-zA-Z0-9_]* }}} in any case, ie. a valid C identifier (allowing "_" as the first character is optional I guess since initial "_" is reserved for the standard library). Is there a reason why we would need to allow the "@" in variable names? Or the minus sign "-" (Erik likes "-" better than "_" I understand but that should likely not be the deciding reason if it makes parsing harder otherwise and/or generates identifiers that cannot be mapped to C/Fortran/Shell variable names ;-) ).