#1872: test system does not detect extra lines in output files -----------------------+---------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: critical | Milestone: ET_2016_11 Component: Cactus | Version: development version Resolution: | Keywords: testsuite -----------------------+----------------------------------------------------
Comment (by knarf):
What about the following? This fixes the problem for me: {{{ @@ -1783,6 +1783,16 @@ sub CompareTestFiles print "TESTSUITE ERROR: Didn't catch case in CompareFiles\n"; } } #while + while ($nline = <INNEW>) + { + # ignore trailing comment lines in new file + last unless ($nline =~ /^\s*(["#].*)?$/); + } + if (!eof(INNEW)) + { + $rundata->{"$thorn $test $file NFAILWEAK"}++; + $rundata->{"$thorn $test $file NFAILSTRONG"}++; + }
} elsif (!-e $newfile && -s $oldfile) }}}