#996: change default values of PUGH's periodic parameters to "no" ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: PUGH ------------------------------------+---------------------------------------
Comment (by eschnett):
Doesn't this patch break existing test cases?
There are two kinds of PUGH parameters to select periodic boundaries: one parameter "periodic" that makes all directions periodic, and direction- specific parameters "periodic_[xyz]" that make only this direction specific. At run time, PUGH computes the logical AND (!) between these.
I suggest, in addition to changing the default values to be all false, to use a logical OR. This way, parameter files using PUGH with periodicity don't have to set several parameters.
Alternatively, we can set these direction-specific parameters to "yes" in Carpet, which would not change its behaviour since the overall "periodic" parameter is still set to "no". (I believe this was also the case at some point.) If any of the periodicity parameter are set in a parameter file, Carpet would still abort. This would not change PUGH's behaviour.
Such a change to Carpet (if it also handles fallout to ensure Carpet still doesn't accept periodicity) is pre-approved.