#815: Outlfow thorn in incoming ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
I suggest to split the thorn into two, one for the analysis, the other for the output. If the ASCII output format introduced by this thorn is useful, it should be generally available (and if it is not useful it shouldn't be there). It is not a good idea to mix numerical analysis and computational infrastructure.
Why does the thorn inherit from ADMBase, but not from Hydrobase? It uses variables from both.
Why are there explicit declarations for 20 grid variables? It would be cleaner if those were stored as array, or (at least) in the same group.
Given this comment "I hard-code the current to use to be the flux of dens in Whisky", why are there 20 grid variables? Couldn't the flux be stored in a single variable? (And shouldn't this be HydroBase instead?)