#1213: GRhydro updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRhydro ------------------------------------+---------------------------------------
Comment (by knarf):
0002: SetTmunu is used in TmunuBase. It might not contain scheduled routines, but thorns referring to it will enforce ordering. If it doesn't exist anymore that ordering will not be enforced anymore. 0002: Isn't HydroBase_RHS used in GRHydro? (schedule group GRHydroRHS IN HydroBase_RHS) 0012: We need a mechanism to make GRHydro_Macros.h usable by other thorns and especially other languages. If used as is currently I cannot write an extra thorn setting things to atmosphere conforming to these new parameters - especially not in C, unless I essentially re-implement the logic - which would be bad code-duplication. This was no issue so far because the logic was so simple. With this patch this would no longer be true. 0013: Can't we have a parameter which activates this by default if Carpet is active and doesn't give an error if it isn't? Otherwise we end up with yet another parameter which people typically set to something different than the default - plus more differences between Carpet and PUGH parameter files which are not really necessary since the code can check if carpet is active or not.
I looked at the short ones and glimpsed at the long patches and didn't find anything obviously wrong.