#683: LSUThorns/Vectors: Remove pos, add sin/cos/tan functions ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
You are asking me to keep uncommitted changes in my repository. This is very inconvenient for me, because that means I have to use diff and patch (and emacs) to create patches, and a different source tree for testing. Also, if someone else wants to work on vectorising integer operations, they'll have to begin from scratch since they don't know about what I did, and if this person implements something from scratch, it will likely be different from mine, making my work irrelevant.
I think we're going way too far here with keeping the trunk and its history clean and perfect. Imagine when EinsteinExact and Metrics will be in the ET -- do you really want to be kept to the same standards when you continue to develop them, with people asking you to break up your existing commits, and asking you to keep commits to yourself unless they are needed, at which time they will be reviewed (and probably changed, requiring you to change other code that relies on them)? It's good to keep code clean, but that has to happen at a much higher level. We should e.g. be discussing the vectorisation API, or which archtictures we want to test regularly, or how we can test performance (which is necessary since vectorisation is a performance optimisation). If we discuss whether to keep a few lines of commented-out code, we've reached a far too low level, we're looking at twigs instead of the forest.