#1817: Update LORENE library ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2017_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
I am not sure of phasing out is possible since the new code does not
read old data files. Unless there is a converter for the data files this would render old files unusable and would mean that groups cannot reproduce old results.
It wouldn't. It is still possible to read those using the old readers. You would use the same code that you used to reproduce old data. It's not as if old releases would go away. And if you really care about reproducibility, wouldn't you start with a Lorene input file, and not a Lorene output file?
For the same reason I do not think that renaming is an option instead
the new LORENE should be named LORENE2 same as CarpetRegrid and CarpetRegrid2.
That is not quite the same. It is quite conceivable that future changes in Lorene would break backward compatibility again and again. It cannot be our goal to support LORENE, LORENE2, LORENE3, and so on. What we can, is support the version that was current at that time. If an older version is required - well, then it shouldn't be hard to dig out an old release.