#1817: Update LORENE library ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2017_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
Does the LORENE C++ API also change?
Yes. The updated version, e.g., uses namespaces for at least part of the code. The old didn't. But it quite likely also does not use them for everything, so you do not want both versions compiled into the same binary.
Ideally it should be able to compile both LORENE and LORENE2 into the
same executable.
I agree. Unfortunately, this seems to be a bad choice in this case.
If not possible then one could at least try that one at least receives
an error before the final link stage
Both providing the same implementation (but different versions) would do exactly that. Cactus does not allow two identical implementations. This would be caught already at CST stage.
It is already sub-optimal to provide two different versions of otherwise the same library. I don't want to introduce a new implementation name for every potentially new version of Lorene. I would strongly prefer the same implementation name, and use versions to make sure that thorns using Lorene within Cactus get the versions they actually work with.