#827: merge bugfixes from Zelmani into main branch ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by bmundim):
* status: review => reviewed_ok
Comment:
Ok, patch 10 looks good to me with two caveats:
1) I don't fully understand assigning psidc as a pseudoscalar yet. However a flat space analysis seems to indicate it is actually a pseudoscalar. divB is clearly a pseudoscalar.
2) divB seems to be calculated twice with this patch in place.
I recommend to apply this patch. We can then fix 2) in the next commit.