#765: NaNChecker should not reduce in local mode ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
The attached patch splits NaNCheckers operation into a local search routine followed by a per-level reduction. It does not use ENTER_LEVEL_MODE to not rely on Carpet's code (ie. to compile without Carpet present). Note that NaNChecker does not trigger the warning in CarpetReduce since it uses reducelocalscalar so does not reduce a grid function (it seems to end up in ReduceArrays inside of CarpetReduce). I attach a test for NaNChecker (using PUGH, which is likely fragily since it relies on IEEE floating point math to create NaNs on the grid).