#713: Implement "Conformal Covariant Z4" formulation in McLachlan ------------------------------------+--------------------------------------- Reporter: barry.wardell | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
Replying to [comment:13 knarf]:
It would be good to make the 'formulation' parameter a keyword, with
'BSSN' the default and 'CCZ4' the only other option (for now). Simply 'formulation' isn't quite describing what it does.
While i agree this would be nice in principal, it has not been done this way for a few reasons:
1. Checking against a keyword is much more computationally expensive than an integer. This check is done inside the rhs assignement in the grid loop in a calculation, so is performance critical. 2. This is not how things are implemented for other parameters, most notably the conformalMethod parameter. 3. I don't know if this is currently possible in reasonable way with Kranc.
However, if someone can suggest a good (i.e. non-hacky) way of implementing it as a keyword parameter, I would be happy to use that instead.