#827: merge bugfixes from Zelmani into main branch ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
I just discussed with Philipp in a bit more details and the status is that in fact the 3d inversion code is not used at all right now since the patch in question only modifies a routine that is not yet used. And even were it used it contains "if" statements on eos_key to switch back to the faster 2d scheme for polytrope and gamma law eos. So the status right now is that we have a fast inversion routine that is used but only works for polytrope and gamma law and a possibly slow routine (with fast fallback) that is designed to work with any eos and which does not obviously fail with a hybrid eos.