#2050: cctk_startupxxx is a valid group ----------------------+----------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: defect | Status: new Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------
Comment (by knarf):
The fix for the regex should go in (line 46), the sooner the better, into the relaase, and you have review_ok for that from me.
As for the rest of the patch:
Lines 200-204 have wrong indentation.
Why do you explicitly abort in line 196 (also, there is some strange indentation going on)? In this case, you already have set level => 0 in $time_bin_info. Couldn't you cause an abort on line 973 instead (removing the if-condition there)? Not directly aborting, but using the latter abort would also not duplicate the definition of $hint. As is, the if-condition on line 973 also makes setting level==0 a noop, but that is done on line 190, so why populate $time_bin_info in line 191 and 192 if that isn't used later?
Also, isn't $where already guaranteed to match schedule_bin_regexp for AT (line 194, already checked in line 563)? Why is this new check necessary?