#814: Allow different timers on different processors in TimerReport ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: TimerReport ------------------------------------+---------------------------------------
Comment (by eschnett):
This patch is okay to apply.
If you want, you can keep the type of all_timernames; there is no need to change from char[][] to char[]. You would write {{{ char (*restrict const all_timernames)[TIMERNAME_LENGTH] = malloc(total_ntimers * sizeof *all_timernames); }}} which would save the explicit index calculations, and would avoid the need to cast the type for compare_string_array. However, this is not necessary to apply the patch.