#1150: Simfactory: it doesn't honor --procs when running testsuites -------------------------+-------------------------------------------------- Reporter: bmundim | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------
Comment (by rhaas):
I certainly was confused about procs as well. In particular since many places in the code use Procs to refer to MPI processes (eg CCTK_NProcs). This might be historical and based on the assumption that there are as many processes as processors (do we mean socket or core by that as well) but is what you are used to when writing MPI code.
So my preference would be to rename --procs to --cores (if this is what the queuing systems wants) and output a warning message if --procs is used. Since I think of procs as MPI processes my personal favourite would be of course to have --procs by MPI processes but that seems impossible to change now since all users of simfactory are now used to the old meaning.
We might also want to have look at how simfactory handles undersubscribing a node eg. run only 2 MPI processes with 4 threads each on a node that has say 16 cores (since one needs lots of memory). I think this is currently possible but would double check that the naming convention there is not "unfortunate". :-)