#216: Thorns in ExternalLibraries should abort if the old "extras" mechanism has been selected --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: ExternalLibraries --------------------------+-------------------------------------------------
Comment (by eschnett):
The patch is fine. I vote to apply it.
Technically, $HDF5 could expand to a string beginning with a minus sign, which would make the test command "[" fail because it will interpret this as option. The suggested solution is to test whether "x$HDF5" is equal to "x" instead of testing "$HDF5" directly. I don't think this is an issue in practice.