#1071: ensure atmosphere is properly set after ID ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
prim2con could run after FillTimeLevels, but then it would have to manually work on all timelevels. This wouldn't be the only function which would need to understand that, so this isn't really feasable as well.
We need to fix this, as it is currently really broken. The only way to have a 'nice' (clean, small) 'fix' would be to depreciate the parameter for a relative atmosphere. However, this would depreciate more than just one parameter, and it would change default behavior, making that problematic as well.
Essentially a lot of functions/thorns are called in Initial/PostInitial and need to work on all levels/timelevels. In between some of them we would need to set the atmosphere, but we cannot know the value for that (if set to relative) before all levels have been set up. I don't see a (nice) way to implement that without changes to Cactus/Carpet atm.
We could implement a partial fix by scheduling atmosphere setting in case an absolute atmosphere is requested. This is straightforward. However, it would still leave relative atmospheres not working.