#545: Use ssh ProxyCommand instead of multiple ssh commands --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
QuoteSafe unfortunately does it's job too well. The way simfactory quotes is not working in all cases, and it is not in this. For instance, the sshcmd is taken into a string which is surrounded by single quotes. If now sshsmd is passed to QuoteSafe, it get additional single quotes around it, messing up with the overall quoting. Agreed, the quoting in simfactory should be improved. E.g. quoting an empty string should result in an empty string. But that is another ticket.
You say the current quoting is off. It works for me. Did you try it and it didn't work for you?
Your concern about multiple trampolines is true: the patch probably does not support that. A better quoting should make that possible in a clean way. However, are multiple trampolines a real concern for anyone?
Ok, I agree that we might not want to use the current patch as it is. Do we agree that we need a better way to quote command line arguments?