#755: Provide better support for implementing boundary conditions --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
The macro looping over boundaries currently looks like {{{ CCTK_LOOP3_BOUNDARIES(name, cctkGH, i,j,k, iblo,jblo,kblo, ibhi,jbhi,kbhi) }}} I suggest to remove the explicit specification of the *lo and *hi arguments, and instead obtain these from thorn CoordBase. A second, "internal" macro would continue to provide the current functionality. This would be done for loops over the interior as well.
The new macros would then look like {{{ CCTK_LOOP3_INTERIOR(name, cctkGH, i,j,k) CCTK_LOOP3_BOUNDARIES(name, cctkGH, i,j,k) }}} and {{{ CCTK_LOOP3_BOUNDARIES_DIRECT(name, cctkGH, i,j,k, iblo,jblo,kblo, ibhi,jbhi,kbhi) }}} and equivalently for the interior.