#1832: Rewrite git handling in Formaline ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
Suggestions: * Formaline is using the SILENT environment variable. Should it instead use the VERBOSE variable that Cactus now uses? Rather than parsing the user-supplied value, can it get the information pre-parsed from the build system? Or is this in fact what SILENT now is? * Is it necessary to perform the size check on the repo before garbage collecting? As I understood it, "git gc" performs its own check for whether it is necessary or not. * It would be nice to have a paragraph at the top of the script explaining what the script does.
Comments: * I would have preferred that the long main function were split into subfunctions, increasing modularity and reducing variable scope, which would also make it easier to see the individual steps, and to understand their inputs and outputs.
I have looked through the code and don't see any major causes for concern, and would be fine with it being committed. However, this close to a release, committing a rewrite might not be a good idea, since this will be used by everyone building the ET. Committing after the release would be fine. If we decide to do that, is it also possible to fix #1830 in the current version easily, or would that require a substantial effort?