#2096: SphericalHarmonicRecon and SphericalHarmonicReconGen tests fail on Jenkins build machine ------------------------------------+--------------------------------------- Reporter: hinder | Owner: rhaas Type: defect | Status: assigned Priority: major | Milestone: ET_2018_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Hmm, so minval is the issue, not minloc? Given your test code, yes, "minval" seems to be the culprit. The smallest change to make things work would be to remove --no-finite-math-only but this makes all calls to isnan return "false" which makes NaNChecker ignore all nans. There's workarounds for that eg by manually looking for bit-pattern that IEEE defines to be NaN rather than using the C (or C++) library's isnan function. This could be encapsulated in the CCTK_IsNaN functions which in turn could be made to override the systems isnan functions. *However* this will fail in Fortran code where the idiom to check for NaN is "if (a.ne.a) then" which involves no function call.
Another option would be to provide our own minval function which may be less efficient but given that it is likely memory bandwidth bound anyway we should do about as good as the compiler supplied version.
Do you know the problem is in minval or in abs?