#1633: backport MoL revision 225 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: MoL backport ---------------------+------------------------------------------------------
Comment (by rhaas):
All of these are sound suggestions. However:
The code fragment is a copy of the lines already in Init_RHS for the regular evolved variables. Hence the names and debug output. I would rather not change names/WARN<->ERROR/etc *only* for the slow sector and not eg also for normal RHS, array RHS, complex RHS etc.
As a matter of fact it would seem much more reasonable to me to rewrite all these routines that are almost identical between array evolved variables, slow evolved variables, evolved variables, complex evolved variables, complex array evolved variables (did I miss any?) such that they all use a common worker routine an a short individual wrapper. Right now MoL has very much code duplication which makes it very hard to change anything since one has to make almost the same change at many places.