#476: GRHydro test suite failures (the ones using McLachlan) ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Ian Hinder replied on the mailing list:
"Set the upper and lower boundary sizes to 2. This is a check which was added to Kranc quite recently to catch cases where people have not used enough boundary or ghost points for the evolution stencil of their code. The "convert from ADMBase" routine uses an advection stencil (which requires two adjacent points) to compute the A and B gauge variables.
"Note that tests which use McLachlan and dissipation will have to be regenerated anyway because the dissipation was corrected. Before commit ec32fb2e34d6a2e8b7534195c16bbc2008835ec3, the dissipation term for X was being added spuriously to the B equation. This is probably harmless but fixing it changes the numerical results. I haven't gotten around to doing this yet. If someone else wants to do it, you should check that the McLachlan test passes before that commit, update to the commit after that one, where the code is regenerated, and check that the test fails. Copy the test output into the test directory, and check that the latest version still passes. Then commit the grhydro test."