#1817: Update LORENE library ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2017_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+---------------------------------------
Comment (by rhaas):
There is no diff or similar of the non-LORENE tarball part of the code, is there? In particular the ccl files, build script, patches etc. If you can easily provide this that would help (the easier to review, the more reviews will happen). It seems that if you use "diff -u" (or just git diff which defaults to that) then trac will highlight the changes visually making it easier to review as well. Of course it could also be that the file needs to have an extension .patch instead of .diff (since the example I looked at had a .patch file).