#1894: EinsteinInitialData/TwoPunctures segfaults and miscalcs with SP, maybe DP too. ---------------------------------+------------------------------------------ Reporter: koppel@… | Owner: Type: defect | Status: reopened Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------
Comment (by koppel@…):
I've addressed the comments and updated the patch.
clamp -> clamp_pm_one. I've also harmonized the formatting with surrounding code.
I've added comments explaining why B should be in [-1,1].
And, just to be safe I added assertions checking for NaNs to PunctTaylorExpandAtArbitPosition and also to PunctEvalAtArbitPositionFast since there are several functions, including square roots, that might cause trouble.