#680: LSUThorns/Vectors: Add kifneg function ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
Replying to [comment:4 eschnett]:
ifmsb is implemented (just called ifneg), ifpos is implemented in terms
of ifneg.
Yes, I saw that. My suggestion is to go ahead with renaming it to ifmsb and then add the trivial definition of ifneg = ifmsb. This would have the advantage that it would mean that only ifmsb would need to be implemented in each of the vectors-*.h files and ifpos/ifneg could be implemented just once in vectors.h
Replying to [comment:5 knarf]:
If I look at line 240, that's inside a definition of k8ifpos, and that
name is not changed. However, the entire block is inside an 'elif 0' - so it should not have an effect in the end. Doesn't this change the definition of k8ifpos inside that block? Could we remove that block at some point anyway, since it will never get executed?
That's how it looks to me too. Is there a reason to keep this if 0'd code around? If there is, then I think the unintentional change in the definition of k8ifpos should be corrected.