#1687: add MPI_INC_DIRS and MPI_LIB_DIRS to HDF5_XXX_DIRS ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
I haven't tried the patch, but it looks to me like you use ${MPI_LIBS} without it ever being set in the script. Does that really work?
Also, the ${MPI_LIBS} are being added unconditionally. Would it be better to do something more like what's done for zlib and conditionally add the appropriate libs dependent on whether H5_HAVE_LIBMPI is set in H5pubconf.h?