#683: LSUThorns/Vectors: Remove pos, add sin/cos/tan functions ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
I agree with both of you. Yes, changes which are not ready should not be committed. In most cases anyway. In this case you made a good point of why they should anyway Erik. What do you think about protecting the integer code with a single #define, which by default disables the code, and which has a comment attached explaining that this is not yet fully implemented? This way you would not have uncommitted code, and users would know why this code isn't used yet.