#888: Add thorn ExternalLibraries/hwloc to Einstein Toolkit ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
A few minor things:
- Typically configure scripts in ExternalLibraries are called THORN.sh - but here you choose configure.sh. Do we want to change this, or change the current 'standard'? It would be nice to have the same naming scheme across all thorns if possible. - The configure script doesn't seem to try to auto-detect an already installed version. Is this not possible or not of interest here? - We can add it before the release, but with the condition that we have to get it to compile on all machines we test on for the release.
So - please add, but we'll have to take it out of the release if we cannot make it work nicely in the short amount of time.