#551: Output metadata from TwoPunctures ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: TwoPunctures ------------------------------------+---------------------------------------
Comment (by eschnett):
Grid scalars and grid arrays are accessible in global mode (since there is only one instance of these scalars and arrays). Only grid functions require local mode (since there are many "instances" of them, i.e. components, patches, and levels).
I wanted to suggest to add these as comments, not as keys. Comments seems more flexible; one could add them (or remove them again) at a later point. They would be for human consumption, so that oneself knew when and were the file was written. All Carpet I/O thorns output such identifiers to their output files. The reason for this is that, sometimes, these output files are passed on to others, e.g. to a visualisation expert, and it then becomes forgotten which simulation created these files, and it then becomes impossible to describe the resulting visualisations, even if they made it to a journal cover.
These are the corresponding lines in CarpetIOASCII:
{{{ if (CCTK_IsFunctionAliased ("UniqueBuildID")) { const char* const build_id = (const char*) UniqueBuildID (cctkGH); file << "# Build ID: " << build_id << eol; } if (CCTK_IsFunctionAliased ("UniqueSimulationID")) { const char* const job_id = (const char*) UniqueSimulationID (cctkGH); file << "# Simulation ID: " << job_id << eol; } if (CCTK_IsFunctionAliased ("UniqueRunID")) { const char* const job_id = (const char*) UniqueRunID (cctkGH); file << "# Run ID: " << job_id << eol; } }}}
The patch is fine without these comments.