#1287: Allow setting parameters at build time --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
The patch removes 'delim'. While it is ok to remove it (it's not used), please do in a separate commit.
The patch removes a workaround for perl 5.004_04 (according to the comment which is also removed). Why? Even with a reason: Please do so in a separate commit.
When you replace the declaration of parameters (CCTK_DECLARE_INIT) you first use 'friend', which is an implementation name and a second time use 'thorn' which is a thorn name. Assuming you meant to use the thorn name here (because you also mentioned that in the description here) wouldn't using '$friend_thorn' instead of '$friend' in the first replacement be better?