#1796: Include IllinoisGRMHD into the Toolkit, as an Arrangement ------------------------------------+--------------------------------------- Reporter: zachetie@… | Owner: Zachariah Etienne Type: enhancement | Status: new Priority: major | Milestone: ET_2015_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRMHD IllinoisGRMHD ------------------------------------+---------------------------------------
Comment (by Zach Etienne):
I have just added a magnetized TOV code test to the IllinoisGRMHD/test directory. This required adding a new thorn called Seed_Magnetic_Fields. I also added a test.ccl file, and verified that the output of make [config name]-testsuite on this test yields:
Success: 21 files identical
Note that this test merely provides a sanity check. In other words, IllinoisGRMHD passing this code test is a necessary but not sufficient condition for acceptance of any IllinoisGRMHD patch; contact me (Zach) for details on the more robust set of tests that must be applied to any IllinoisGRMHD patch that might conceivably result in beyond-roundoff differences to the original version. Our #1 goal is to ensure roundoff- error identity with the original IllinoisGRMHD. Otherwise we risk getting the science wrong.
Frank: Please review the new Seed_Magnetic_Fields at your earliest convenience; it's only 51 lines, not including the .ccl files.