#1772: Simfactory: potentially serious problem with CACHE directory in the simulations directory -------------------------+-------------------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: new Priority: critical | Milestone: ET_2015_05 Component: SimFactory | Version: development version Resolution: | Keywords: CACHE -------------------------+--------------------------------------------------
Comment (by eschnett):
The logic to copy instead of hard link was added later, as an error handling mechanism. The logic without this mechanism should be easier to understand. I did not want to rewrite the whole algorithm since it was working correctly. It may now be time to introduce a new function "create_hardlink_or_copy" that does this, and which also checks for erroneous soft links.
Yes, the logic to compare files apparently only looks at sizes and dates. That was presumably a performance optimization that works well in practice.