#1817: Update LORENE library ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2017_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+---------------------------------------
Comment (by knarf):
Replying to [comment:20 rhaas]:
In line "36 unset LIBS" if gfortran is required, what about ifort?
Good catch. I added those as well, and tested with both. I don't like a white list like this in general, but linking both fortran and c++ seems to be messy like this, and we cannot simply take all LIBS from Cactus.
In line "125 # build some utilities available with the LORENE library"
shouldn't the copying of utilities be done via the makefile where UTIL_DIR is defined so that eg it is re-created after wiping the exe directory (minor)?
Ideally it should do it later, but external libraries are pruned even inside the build phase, so one would need to create a temporary location, or alternatively, unpack part of the tarball again. I wanted to avoid this complication.
In line "13 $(SCRATCH_BUILD)/done/$(THORN): $(SRCDIR)/build.sh " you are
removing the tarball and the patches from the build dependencies. Did this not work before? Otherwise it would seem good to re-build LORENE when the tarball or the patches are changed.
Good catch. This was a left-over from the time when this wasn't a tarball. It's in again.
My comments with regards to thorn and implementation naming still apply.
Yes, those will need to be figured out as well. I still think that using the same implementation name is ok, especially keeping in mind that now Meudon_Bin_NS works with both versions (but obviously not at the same time). The only issue to sort out is the thorn name, but the ticket isn't the right place to do so.